Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 )
Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10543/1/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: http://gerrit.cloudera.org:8080/#/c/10543/1/tests/metadata/test_partition_metadata.py@159 PS1, Line 159: assert data.split('\t') == ['21', '6'] > Hmm. This is one feasible solution for sure and I think it's also easy to i Discussed this with Alan and Vuk offline. We discussed various possible approaches to the drop issue and we think the saner way here is for Impala to raise an "error" when the user tries to drop a partition which shares location with other partitions. The reason being that the HMS dangerously deletes the backing partition data (in case of managed tables) and the users could complain of a data loss when Impala/Hive already knows that multiple partitions point to it. Of course we cannot control how Hive deals with it, but at least we could raise a meaningful error from the Impala side and ask the user to fix the other partitions before the drop can continue. Thoughts? (Adding Vuk to the reviewers list to keep him in loop). -- To view, visit http://gerrit.cloudera.org:8080/10543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54bc8224bcefe65b83de2df58bb84629f2aa4a Gerrit-Change-Number: 10543 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 17:56:39 +0000 Gerrit-HasComments: Yes
