Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10543 )
Change subject: IMPALA-6119: Fix issue with multiple partitions sharing same location ...................................................................... Patch Set 15: Code-Review+1 (6 comments) +2 for the code (once the remaining nits are fixed). Marking +1 incase someone needs to look at tests. Adding Michael Brown. @Michael: Can you +2 the tests part? http://gerrit.cloudera.org:8080/#/c/10543/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10543/15//COMMIT_MSG@21 PS15, Line 21: It's no longer allowed to drop a partition that shares it's location For managed tables,... http://gerrit.cloudera.org:8080/#/c/10543/15/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10543/15/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1202 PS15, Line 1202: HashSet<HdfsPartition> partitions = locationToPartMap_.get(location); Preconditions.checkNotNull(partitions); http://gerrit.cloudera.org:8080/#/c/10543/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/10543/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2244 PS15, Line 2244: tbl instanceof HdfsTable Remove. This already holds via L2229. http://gerrit.cloudera.org:8080/#/c/10543/15/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: http://gerrit.cloudera.org:8080/#/c/10543/15/tests/metadata/test_partition_metadata.py@173 PS15, Line 173: Impala : then Impala Typo http://gerrit.cloudera.org:8080/#/c/10543/15/tests/metadata/test_partition_metadata.py@174 PS15, Line 174: partition Remove http://gerrit.cloudera.org:8080/#/c/10543/15/tests/metadata/test_partition_metadata.py@209 PS15, Line 209: Catalog keeps track of j=3 partition Update -- To view, visit http://gerrit.cloudera.org:8080/10543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a54bc8224bcefe65b83de2df58bb84629f2aa4a Gerrit-Change-Number: 10543 Gerrit-PatchSet: 15 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 22:23:28 +0000 Gerrit-HasComments: Yes
