ji chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/23613 )
Change subject: IMPALA-14092 Part2: Support querying of paimon data table via JNI ...................................................................... Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/23613/12/be/src/exec/paimon/paimon-jni-scan-node.cc File be/src/exec/paimon/paimon-jni-scan-node.cc: http://gerrit.cloudera.org:8080/#/c/23613/12/be/src/exec/paimon/paimon-jni-scan-node.cc@143 PS12, Line 143: env, &array, &schema, &row_ > clang-tidy complain here. Done http://gerrit.cloudera.org:8080/#/c/23613/12/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java File fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java: http://gerrit.cloudera.org:8080/#/c/23613/12/fe/src/main/java/org/apache/impala/catalog/paimon/PaimonUtil.java@879 PS12, Line 879: pub > nit: add a whitespace before. Done http://gerrit.cloudera.org:8080/#/c/23613/12/fe/src/main/java/org/apache/impala/planner/PaimonScanNode.java File fe/src/main/java/org/apache/impala/planner/PaimonScanNode.java: http://gerrit.cloudera.org:8080/#/c/23613/12/fe/src/main/java/org/apache/impala/planner/PaimonScanNode.java@86 PS12, Line 86: (PlanNodeI > fieldIdSet_ ? Done http://gerrit.cloudera.org:8080/#/c/23613/12/fe/src/main/java/org/apache/impala/planner/paimon/PaimonSplit.java File fe/src/main/java/org/apache/impala/planner/paimon/PaimonSplit.java: http://gerrit.cloudera.org:8080/#/c/23613/12/fe/src/main/java/org/apache/impala/planner/paimon/PaimonSplit.java@28 PS12, Line 28: /** : * Paimon split entity used by paimon jni scanner. : * */ : public class PaimonSplit implements Serializable > Please add class and field documentations here. Done -- To view, visit http://gerrit.cloudera.org:8080/23613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie679a89a8cc21d52b583422336b9f747bdf37384 Gerrit-Change-Number: 23613 Gerrit-PatchSet: 13 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 08:46:57 +0000 Gerrit-HasComments: Yes
