Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23613 )
Change subject: IMPALA-14092 Part2: Support querying of paimon data table via JNI ...................................................................... Patch Set 13: Code-Review+1 (4 comments) Few nits, otherwise LGTM! http://gerrit.cloudera.org:8080/#/c/23613/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23613/13//COMMIT_MSG@46 PS13, Line 46: will in nit: will be in http://gerrit.cloudera.org:8080/#/c/23613/13/be/src/exec/paimon/paimon-jni-row-reader.h File be/src/exec/paimon/paimon-jni-row-reader.h: http://gerrit.cloudera.org:8080/#/c/23613/13/be/src/exec/paimon/paimon-jni-row-reader.h@53 PS13, Line 53: arraw_array nit: arrow_array http://gerrit.cloudera.org:8080/#/c/23613/13/be/src/exec/paimon/paimon-scan-plan-node.cc File be/src/exec/paimon/paimon-scan-plan-node.cc: http://gerrit.cloudera.org:8080/#/c/23613/13/be/src/exec/paimon/paimon-scan-plan-node.cc@18 PS13, Line 18: #include "exec/paimon/paimon-scan-plan-node.h" : #include "common/status.h" : #include "exec/paimon/paimon-jni-scan-node.h" nit: strange include order http://gerrit.cloudera.org:8080/#/c/23613/9/fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java: http://gerrit.cloudera.org:8080/#/c/23613/9/fe/src/main/java/org/apache/impala/catalog/local/LocalPaimonTable.java@68 PS9, Line 68: applyPaimonTableStatsIfPresent(); > Done It's marked as Done, but we still add those. But I don't mind if there's any reason for this. -- To view, visit http://gerrit.cloudera.org:8080/23613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie679a89a8cc21d52b583422336b9f747bdf37384 Gerrit-Change-Number: 23613 Gerrit-PatchSet: 13 Gerrit-Owner: ji chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: ji chen <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 16:27:09 +0000 Gerrit-HasComments: Yes
