Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23781 )
Change subject: IMPALA-14284: Log the actual log files instead of symlinks in start-impala-cluster.py ...................................................................... Patch Set 1: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py@264 PS1, Line 264: LOG.error("Log symlink {0} does not exist yet".format(log_symlink)) When I tried this, most services started normally but I saw Log symlink /home/msmith2.linux/impala/logs/cluster/catalogd.INFO does not exist yet reported. I'm not sure how to cleanly avoid that; maybe it's not very important to report? http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py@816 PS1, Line 816: print_actual_log_file(log_symlink) > Shouldn't we print this before raising the RuntimeError too? It points to c I guess this is just checking for process startup, not whether the service is available. I could go either way on reporting this one. -- To view, visit http://gerrit.cloudera.org:8080/23781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id76c0a8bdfb221ab24ee315e2e273abca4257398 Gerrit-Change-Number: 23781 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 12 Dec 2025 17:14:17 +0000 Gerrit-HasComments: Yes
