Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23781 )
Change subject: IMPALA-14284: Log the actual log files instead of symlinks in start-impala-cluster.py ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py@251 PS1, Line 251: > Please fix. Done http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py@264 PS1, Line 264: sleep(1) > When I tried this, most services started normally but I saw I can remove this. It's just for my debug purpose. http://gerrit.cloudera.org:8080/#/c/23781/1/bin/start-impala-cluster.py@816 PS1, Line 816: > I guess this is just checking for process startup, not whether the service When the process fails to start, the previous log symlink might still exist and point to the log file of a previous run. So I think it'd be better to only print this after the process succeeds to start. -- To view, visit http://gerrit.cloudera.org:8080/23781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id76c0a8bdfb221ab24ee315e2e273abca4257398 Gerrit-Change-Number: 23781 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 13 Dec 2025 00:13:07 +0000 Gerrit-HasComments: Yes
