Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22094 )
Change subject: IMPALA-13533: Calcite CTE backend ...................................................................... Patch Set 24: (3 comments) http://gerrit.cloudera.org:8080/#/c/22094/22/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java File fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java: http://gerrit.cloudera.org:8080/#/c/22094/22/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@167 PS22, Line 167: } else if (root instanceof CTEConsumerNode) { > Optional food for thought: Seems like the general pattern with the other "i I'll consider it, especially once I figure out what to do about the TODO at 174. http://gerrit.cloudera.org:8080/#/c/22094/22/fe/src/main/java/org/apache/impala/planner/DistributedPlanner.java@172 PS22, Line 172: result = childFragments.get(0); > Optional nit: flip this statement with line 173 and change this to result.a Done http://gerrit.cloudera.org:8080/#/c/22094/22/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/22094/22/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@933 PS22, Line 933: // all ExchangeNodes have registered input fragments; collect them, ignoring CTEs > nit: change comment Done -- To view, visit http://gerrit.cloudera.org:8080/22094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a Gerrit-Change-Number: 22094 Gerrit-PatchSet: 24 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sat, 13 Dec 2025 00:09:33 +0000 Gerrit-HasComments: Yes
