Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22094 )

Change subject: IMPALA-13533: Calcite CTE backend
......................................................................


Patch Set 24:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22094/24/be/src/runtime/local-exchanger.h
File be/src/runtime/local-exchanger.h:

http://gerrit.cloudera.org:8080/#/c/22094/24/be/src/runtime/local-exchanger.h@58
PS24, Line 58:   Status Push(std::unique_ptr<RowBatch> batch);
Consider adding a backpressure mechanism. Needs to co-exist with union though, 
I'm not sure how I'd implement it without updating union to pull from all its 
children.



--
To view, visit http://gerrit.cloudera.org:8080/22094
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48f16d495d4b37be97e6a913f0eb5b94d70e199a
Gerrit-Change-Number: 22094
Gerrit-PatchSet: 24
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Sat, 13 Dec 2025 00:37:35 +0000
Gerrit-HasComments: Yes

Reply via email to