Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@8 PS3, Line 8: : We need better observability for the admission state map to warn : about potential memory leaks. : > nit: Can you tell us a bit about the behavior of admission state map in com Done. Updated the commit message. http://gerrit.cloudera.org:8080/#/c/23760/3//COMMIT_MSG@16 PS3, Line 16: the removal l > Why not use existing AtomicHighWaterMarkGauge? We use FunctionGauge because it reads the map size directly. We don't need to manually update a counter every time we add or delete from the map, which AtomicHighWaterMarkGauge would require. For example, in https://gerrit.cloudera.org/#/c/23763/, we don't need to update anything about this gauge when we add a delete. -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 15 Dec 2025 23:55:22 +0000 Gerrit-HasComments: Yes
