Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23760 )
Change subject: IMPALA-14612: Add global metrics for admission state map size ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23760/5/common/thrift/metrics.json File common/thrift/metrics.json: http://gerrit.cloudera.org:8080/#/c/23760/5/common/thrift/metrics.json@3962 PS5, Line 3962: "key": "admission-control-service.admission-state-map-size", : "label": "Admission Control Service Admission State Map Size", Rather than Admission state map, I would recommend naming it to something that is more straightforward to user. How about this? "key": "admission-control-service.num-queries", "label": "Num Queries in Admission Control Service", "description": "The number of queries currently registered in Admission Control Service (queuing or running) and not yet fully released.", Similar comment for the HWM metric. -- To view, visit http://gerrit.cloudera.org:8080/23760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie803aabf8d91b6381c5d0d7534cd9c9fc2166a73 Gerrit-Change-Number: 23760 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 17 Dec 2025 03:59:20 +0000 Gerrit-HasComments: Yes
