Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/10726 )
Change subject: Fail cleanly when in process server can't bind ...................................................................... Patch Set 1: Code-Review+1 I thought a bit about not too intrusive ways to reduce the window where a port number is already decided but the port itself is unbound. A static/global port number->socket fd map could be created, and FindUnusedEphemeralPort() could add the fd to this map instead of closing it. Another static function like "ClosePortIfReserved()" could be called as close as possible to the place where the port is bound to socket by the actual server. This function would be a noop if the port is not in the map, so caller would not have to know if the port was "reserved" or not. -- To view, visit http://gerrit.cloudera.org:8080/10726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I376a2aa559f4b5cf3b96fa3465520e9983ecec4b Gerrit-Change-Number: 10726 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Comment-Date: Fri, 15 Jun 2018 12:11:40 +0000 Gerrit-HasComments: No
