Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10726 )
Change subject: Fail cleanly when in process server can't bind ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10726/1/be/src/testutil/in-process-servers.h File be/src/testutil/in-process-servers.h: http://gerrit.cloudera.org:8080/#/c/10726/1/be/src/testutil/in-process-servers.h@55 PS1, Line 55: /// forwarded to the ExecEnv. can you specify whether *server is set only when OK is returned, or if it might be set even if an error is returned. -- To view, visit http://gerrit.cloudera.org:8080/10726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I376a2aa559f4b5cf3b96fa3465520e9983ecec4b Gerrit-Change-Number: 10726 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 21:59:18 +0000 Gerrit-HasComments: Yes
