Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23831 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23831/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23831/2//COMMIT_MSG@9 PS2, Line 9: Leave HS2-HTTP connections open and retry on 401 or EPIPE failures to : re-use connections, greatly reducing the number of client connections : needed with the HS2-HTTP protocol. It could be useful to add a config to turn config reuse off. I see 2 uses: - turn it off in production if it turns out that it causes issues - turn it off in tests to avoid extra complexity like in cookie tests http://gerrit.cloudera.org:8080/#/c/23831/2/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23831/2/shell/impala_shell/ImpalaHttpClient.py@429 PS2, Line 429: Can you add a comment about not retrying on socket errors after some data was already sent to avoid repeating any data? It could be also mentioned that the whole thing is needed because http_client doesn't expose the socket so we can't check before sendRequestHeaders() if the socket is broken. -- To view, visit http://gerrit.cloudera.org:8080/23831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafb3fc39817e93c691cd993902c6d939a7235a03 Gerrit-Change-Number: 23831 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 09:04:03 +0000 Gerrit-HasComments: Yes
