Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23831 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23831/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23831/2//COMMIT_MSG@9 PS2, Line 9: Leave HS2-HTTP connections open and retry on 401 or EPIPE failures to : re-use connections, greatly reducing the number of client connections : needed with the HS2-HTTP protocol. > It could be useful to add a config to turn config reuse off. I see 2 uses: Done http://gerrit.cloudera.org:8080/#/c/23831/2/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23831/2/shell/impala_shell/ImpalaHttpClient.py@429 PS2, Line 429: except socket.error as e: > Can you add a comment about not retrying on socket errors after some data w Done -- To view, visit http://gerrit.cloudera.org:8080/23831 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iafb3fc39817e93c691cd993902c6d939a7235a03 Gerrit-Change-Number: 23831 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Farkas <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jan 2026 19:23:37 +0000 Gerrit-HasComments: Yes
