Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23800 )
Change subject: IMPALA-14555: Add Iceberg support for SHOW PARTITIONS WHERE ...................................................................... Patch Set 3: (10 comments) http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@258 PS3, Line 258: <complex predicate> Please give an example instead of vague <complex predicate>. The example should be SHOW query. not SELECT query. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@260 PS3, Line 260: IMPALA-14555 This patch is the solution for IMPALA-14555. Please file a new JIRA ticket to address complex predicates for SHOW (as follow up for IMPALA-14555) and put that new JIRA number here. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@307 PS3, Line 307: private void analyzeHdfsWhereClause(Analyzer analyzer, TableRef tableRef) : throws AnalysisException { Add Preconditions that tableRef is instance of FeFsTable or change tableRef parameter type to FeFsTable. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@535 PS3, Line 535: org.apache.iceberg.expressions.Expression filterExpr Add @Nullable annotation. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@547 PS3, Line 547: : TResultSet result = createEmptyPartitionStatsResult(); nit: You can move this to the beginning of method and let L544 return result, which is still an empty TResultSet. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@569 PS3, Line 569: public Make this private. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@596 PS3, Line 596: org.apache.iceberg.expressions.Expression filterExpr Add @Nullable annotation here. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@607 PS3, Line 607: Map<String, TIcebergPartitionStats> nameToStats = new HashMap<>(); Before this, add Preconditions that filterExpr is not null. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1742 PS3, Line 1742: TResultSet filteredIcebergPartitionStats Add @Nullable annotation. http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1757 PS3, Line 1757: TResultSet filteredIcebergPartitionStats Add @Nullable annotation. -- To view, visit http://gerrit.cloudera.org:8080/23800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c0ee4d171ae939770725d89dc504e13f82a7688 Gerrit-Change-Number: 23800 Gerrit-PatchSet: 3 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 04:58:16 +0000 Gerrit-HasComments: Yes
