Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23800 )
Change subject: IMPALA-14555: Add Iceberg support for SHOW PARTITIONS WHERE ...................................................................... Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@258 PS3, Line 258: rtitioned WHERE upp > Please give an example instead of vague <complex predicate>. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@260 PS3, Line 260: CT * FROM fu > This patch is the solution for IMPALA-14555. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@307 PS3, Line 307: /** : * Analyzes the WHERE clause f > Add Preconditions that tableRef is instance of FeFsTable or change tableRef Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@535 PS3, Line 535: null for no filtering > Add @Nullable annotation. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@547 PS3, Line 547: org.apache.iceberg.expressions.Expressions.alwaysFalse())) { : // Return empty result for alwaysFalse > nit: You can move this to the beginning of method and let L544 return resul Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@569 PS3, Line 569: * Cre > Make this private. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@596 PS3, Line 596: n key to partition stats, ordered by partition key > Add @Nullable annotation here. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@607 PS3, Line 607: (oldValue, newValue) -> oldValue, LinkedHashMap::new)); > Before this, add Preconditions that filterExpr is not null. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1742 PS3, Line 1742: @Nullable TResultSet filteredIcebergPart > Add @Nullable annotation. Done http://gerrit.cloudera.org:8080/#/c/23800/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1757 PS3, Line 1757: @Nullable TResultSet filteredIcebergPart > Add @Nullable annotation. Done -- To view, visit http://gerrit.cloudera.org:8080/23800 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c0ee4d171ae939770725d89dc504e13f82a7688 Gerrit-Change-Number: 23800 Gerrit-PatchSet: 4 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 12 Jan 2026 06:38:12 +0000 Gerrit-HasComments: Yes
