Daniel Vanko has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23833 )

Change subject: IMPALA-14341: Iceberg MetaProviders Blacklist DBs/Tables
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23833/12/fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java
File fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java:

http://gerrit.cloudera.org:8080/#/c/23833/12/fe/src/main/java/org/apache/impala/service/catalogmanager/LocalImpl.java@113
PS12, Line 113: IcebergMetaProvider
update to "BlacklistingMetaProvider or IcebergMetaProvider"?


http://gerrit.cloudera.org:8080/#/c/23833/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog-blacklist-db.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog-blacklist-db.test:

http://gerrit.cloudera.org:8080/#/c/23833/12/testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-catalog-blacklist-db.test@14
PS12, Line 14: ====
Can you add a test for trying to create a blacklisted database?



--
To view, visit http://gerrit.cloudera.org:8080/23833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73a06d30dcdbb579f92c2afa5928beb6c5a13348
Gerrit-Change-Number: 23833
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Thu, 15 Jan 2026 16:50:22 +0000
Gerrit-HasComments: Yes

Reply via email to