Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23833 )

Change subject: IMPALA-14341: Iceberg MetaProviders Blacklist DBs/Tables
......................................................................


Patch Set 12:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23833/12/fe/src/main/java/org/apache/impala/catalog/local/BlacklistingMetaProvider.java
File 
fe/src/main/java/org/apache/impala/catalog/local/BlacklistingMetaProvider.java:

http://gerrit.cloudera.org:8080/#/c/23833/12/fe/src/main/java/org/apache/impala/catalog/local/BlacklistingMetaProvider.java@84
PS12, Line 84: return
Maybe we could add a quick check: if there aren't any blacklisted DBs then just 
return delegate.loadDbList().


http://gerrit.cloudera.org:8080/#/c/23833/12/fe/src/main/java/org/apache/impala/catalog/local/BlacklistingMetaProvider.java@94
PS12, Line 94: return
If we had a collection of the DBs with filtered tables, we could check if 
'dbName' is in that collection, and if not, then we can just return 
delegate.loadTableList().



--
To view, visit http://gerrit.cloudera.org:8080/23833
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I73a06d30dcdbb579f92c2afa5928beb6c5a13348
Gerrit-Change-Number: 23833
Gerrit-PatchSet: 12
Gerrit-Owner: Jason Fehr <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Vanko <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 21 Jan 2026 10:51:40 +0000
Gerrit-HasComments: Yes

Reply via email to