Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23857 )

Change subject: IMPALA-12918: Validate numeric values for table stats properties
......................................................................


Patch Set 4:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23857/4/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java
File 
fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/23857/4/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@454
PS4, Line 454:         StatsSetupConst.ROW_COUNT, StatsSetupConst.TOTAL_SIZE, 
StatsSetupConst.RAW_DATA_SIZE
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d
Gerrit-Change-Number: 23857
Gerrit-PatchSet: 4
Gerrit-Owner: Kunal Siyag <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kunal Siyag <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Wed, 21 Jan 2026 10:51:45 +0000
Gerrit-HasComments: Yes

Reply via email to