Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23857 )
Change subject: IMPALA-12918: Validate numeric values for table stats properties ...................................................................... Patch Set 5: (3 comments) Thanks for the changes, it looks nice! I just added a few nitpicks about the comments. http://gerrit.cloudera.org:8080/#/c/23857/5/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/23857/5/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@150 PS5, Line 150: (IMPALA-12918) No need to add ticket number. We usually add it when the context is too complex for a comment but important, e.g. regression tests. http://gerrit.cloudera.org:8080/#/c/23857/5/fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java@448 PS5, Line 448: * Empty strings and non-numeric values will cause an AnalysisException. : * See IMPALA-12918. Redundant comment. Please be as concise as possible. http://gerrit.cloudera.org:8080/#/c/23857/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/23857/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@1192 PS5, Line 1192: (IMPALA-12918) No need to add the ticket number. -- To view, visit http://gerrit.cloudera.org:8080/23857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d Gerrit-Change-Number: 23857 Gerrit-PatchSet: 5 Gerrit-Owner: Kunal Siyag <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kunal Siyag <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 16:01:51 +0000 Gerrit-HasComments: Yes
