Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23900 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23900/5/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/23900/5/be/src/service/query-options.cc@1396 PS5, Line 1396: case TImpalaQueryOptions::RUNTIME_PLANNERS: { : std::vector<TPlannerType::type> runtime_planners; : const string planners = std::regex_replace(value, std::regex("^\"|\"$"), ""); : vector<string> str_types; : split(str_types, planners, is_any_of(","), token_compress_on); : TrimAndRemoveEmptyString(str_types); : for (const auto& t : str_types) { : TPlannerType::type planner_type; : RETURN_IF_ERROR(GetThriftEnum(t, "planner type", : _TPlannerType_VALUES_TO_NAMES, &planner_type)); : runtime_planners.push_back(planner_type); : } : query_options->__set_runtime_planners(runtime_planners); > Does this produce an error if runtime_planners is empty? It's possible to a It doesn't, but this might be tricky? I actually tried this while testing. If I set it to empty, it goes back to the default ORIGINAL. I suppose that didn't apply to enabled_runtime_filter_types which is empty by default (prolly?) -- To view, visit http://gerrit.cloudera.org:8080/23900 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1fdc5ef92fff84e89af0e19c4246cc15e2ea823 Gerrit-Change-Number: 23900 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 27 Jan 2026 23:55:30 +0000 Gerrit-HasComments: Yes
