Noemi Pap-Takacs has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23857 )
Change subject: IMPALA-12918: Validate numeric values for table stats properties ...................................................................... IMPALA-12918: Validate numeric values for table stats properties Added validation to ensure that table stats properties (numRows, totalSize, rawDataSize) contain valid numeric values in ALTER TABLE SET TBLPROPERTIES statements. Empty strings and non-numeric values will now cause an AnalysisException to be thrown. Testing: - Added tests in AnalyzeDDLTest.java to verify validation logic Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d Reviewed-on: http://gerrit.cloudera.org:8080/23857 Reviewed-by: Noemi Pap-Takacs <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/AlterTableSetTblProperties.java M fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java 2 files changed, 51 insertions(+), 0 deletions(-) Approvals: Noemi Pap-Takacs: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/23857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d Gerrit-Change-Number: 23857 Gerrit-PatchSet: 9 Gerrit-Owner: Kunal Siyag <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kunal Siyag <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]>
