Kunal Siyag has posted comments on this change. ( http://gerrit.cloudera.org:8080/23857 )
Change subject: IMPALA-12918: Validate numeric values for table stats properties ...................................................................... Patch Set 7: > (1 comment) > > I see you edited the comments, thank you! Please don't forget to > address the comment (delete the Jira ticket number) on L150 in > AlterTableSetTblProperties.java. After that, the change is ready to > go! > > A little help for code reviews: You can reply to the comments you > get in gerrit. Please use this functionality as it helps both you > and the reviewers a lot to track what you changed in the patch set! > Just click on 'Done' and send it as a reply to the comments that > you addressed in your patch set. > It is a good practice to always reply to every comment you get, > even if you do not agree with the comment or you plan to fix it > later. You can start a discussion, give feedback, or just note that > you will address it later. > > Thank you! Done with the changes. Thank you for the guidance. Will keep that in mind for the future contributions. -- To view, visit http://gerrit.cloudera.org:8080/23857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5e8f2a9784edc86838a375d373e2095dd674d63d Gerrit-Change-Number: 23857 Gerrit-PatchSet: 7 Gerrit-Owner: Kunal Siyag <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kunal Siyag <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 28 Jan 2026 13:28:46 +0000 Gerrit-HasComments: No
