Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23919 )
Change subject: IMPALA-14710: Fixed flaky test in TestReduceExprShuttle ...................................................................... Patch Set 1: Yup, I know exactly why it was "flaky", which is to say that there is logic behind it, so it is reproducible and not really flaky. When it ran this way: mvn clean install test ...it would run CalcitePlannerTest first. This had a call to CalciteCompilerFactory via the "Frontend.getExecRequest". Within CalciteCompilerFactory, the System variable gets set via a static initializer. When I run it this way: mvn clean install -Dtest=TestReduceExprShuttle ...there is no call to CalciteCompilerFactory, and the static initializer within CalciteCompilerFactory is not called. This would never happen in production code, this is special to a unit testing environment. -- To view, visit http://gerrit.cloudera.org:8080/23919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecb124f43bd7090411bdf1bb8203c15d75158154 Gerrit-Change-Number: 23919 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 29 Jan 2026 23:59:18 +0000 Gerrit-HasComments: No
