Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23919 )
Change subject: IMPALA-14710: Fixed flaky test in TestReduceExprShuttle ...................................................................... IMPALA-14710: Fixed flaky test in TestReduceExprShuttle The charset system property is being set in CalciteCompilerFactory. It seems that if this test is run via mvn clean install test ...it runs fine, but if it is called via mvn clean install -Dtest=TestReduceExprShuttle#testFoldConcatString ... the static initializer isn't called. This could either be fixed by importing CalciteCompilerFactory or explicitly setting the static initializer in this class. The latter was chosen because it would be awkward to have a java class only imported due to a static initializer. However, the downside is that this is duplicate code. Change-Id: Iecb124f43bd7090411bdf1bb8203c15d75158154 Reviewed-on: http://gerrit.cloudera.org:8080/23919 Reviewed-by: Joe McDonnell <[email protected]> Reviewed-by: Michael Smith <[email protected]> Tested-by: Michael Smith <[email protected]> --- M java/calcite-planner/src/test/java/org/apache/impala/planner/TestReduceExprShuttle.java 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Joe McDonnell: Looks good to me, but someone else must approve Michael Smith: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/23919 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iecb124f43bd7090411bdf1bb8203c15d75158154 Gerrit-Change-Number: 23919 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
