Noemi Pap-Takacs has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23913 )

Change subject: Introduce CacheableTable interface
......................................................................


Patch Set 4:

(2 comments)

Thanks for working on the refactoring!

Could you explain the motivation behind this change, and the role of this 
interface in a comment at its definition? (E.g. why divide filesystem tables by 
this attribute and what is the deciding factor here.)
Do you plan to extend this interface or introduce other interfaces?

http://gerrit.cloudera.org:8080/#/c/23913/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23913/4//COMMIT_MSG@10
PS4, Line 10: local fs table
Do you mean HDFS as the file system or the HdfsTable and LocalFsTable classes 
that represent Hive tables?


http://gerrit.cloudera.org:8080/#/c/23913/4//COMMIT_MSG@10
PS4, Line 10: the
nit: delete 'the'



--
To view, visit http://gerrit.cloudera.org:8080/23913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac31211f654f4287a6b27bfe7a478e35faad59f9
Gerrit-Change-Number: 23913
Gerrit-PatchSet: 4
Gerrit-Owner: Nandor Kollar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>
Gerrit-Comment-Date: Sat, 31 Jan 2026 11:13:27 +0000
Gerrit-HasComments: Yes

Reply via email to