Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/23889 )
Change subject: IMPALA-12027: Support additional details for DataSink nodes in ExecSummary ...................................................................... Patch Set 1: (4 comments) I think test_observability.py might be a good place for e2e tests. http://gerrit.cloudera.org:8080/#/c/23889/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23889/1//COMMIT_MSG@9 PS1, Line 9: In the 'Exec Summary' table, we currently show table names, joins and : other details for different types of `PlanNode`s with the help of : `label_detail` field in the thrift representation(i.e. `TPlanNode`). : : This field is currently unavailable for any type of `DataSink` nodes. Please avoid using "currently" when you refer to the old behavior. e.g. "In the 'Exec Summary' table, we show table names, joins and other details for different types of `PlanNode`s with the help of `label_detail` field in the thrift representation(i.e. `TPlanNode`)." http://gerrit.cloudera.org:8080/#/c/23889/1//COMMIT_MSG@15 PS1, Line 15: With this change, we support nit: This change adds support for http://gerrit.cloudera.org:8080/#/c/23889/1/common/thrift/DataSinks.thrift File common/thrift/DataSinks.thrift: http://gerrit.cloudera.org:8080/#/c/23889/1/common/thrift/DataSinks.thrift@187 PS1, Line 187: // Additional details that should be printed to the user. This is node specific : // e.g. table name, join strategy, etc. : 11: optional string label_detail The new field should go to the end of the structure. http://gerrit.cloudera.org:8080/#/c/23889/1/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java File fe/src/main/java/org/apache/impala/planner/MultiDataSink.java: http://gerrit.cloudera.org:8080/#/c/23889/1/fe/src/main/java/org/apache/impala/planner/MultiDataSink.java@102 PS1, Line 102: protected String getLabelDetail() { : return ""; : } MultiDataSinks also write to 1 table. We could also display the table name for them. -- To view, visit http://gerrit.cloudera.org:8080/23889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2652dd896f72c5c6bbe7e76facdede2a237808d5 Gerrit-Change-Number: 23889 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Sat, 31 Jan 2026 11:21:00 +0000 Gerrit-HasComments: Yes
