Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23889 )
Change subject: IMPALA-12027: Support additional details for DataSink nodes in ExecSummary ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23889/1/common/thrift/DataSinks.thrift File common/thrift/DataSinks.thrift: http://gerrit.cloudera.org:8080/#/c/23889/1/common/thrift/DataSinks.thrift@187 PS1, Line 187: // Estimated execution stats generated by the planner. : 7: optional ExecStats.TExecStats estimated_stats : > The new field should go to the end of the structure. Done. I found across some thrift files that reordering helped for better semantics / readability at times. So, then the standard is to put new field at the end? -- To view, visit http://gerrit.cloudera.org:8080/23889 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2652dd896f72c5c6bbe7e76facdede2a237808d5 Gerrit-Change-Number: 23889 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 13:00:55 +0000 Gerrit-HasComments: Yes
