Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23935 )
Change subject: IMPALA-14719: Fixed race condition for Calcite property ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23935/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23935/3/fe/src/main/java/org/apache/impala/service/Frontend.java@3780 PS3, Line 3780: private CompilerFactory getCalciteCompilerFactory(PlanCtx ctx) : throws ImpalaException { Can't we have threading issues here and set the singleton multiple times? BTW what is the reason for initializing calcite compiler only on demand - is it slow / needs a lot of memory? It seems simple to me to always initialize it on startup. -- To view, visit http://gerrit.cloudera.org:8080/23935 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff Gerrit-Change-Number: 23935 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Wed, 04 Feb 2026 09:10:36 +0000 Gerrit-HasComments: Yes
