Hello Aman Sinha, Fang-Yu Rao, Peter Rozsa, Joe McDonnell, Csaba Ringhofer,
Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23935
to look at the new patch set (#4).
Change subject: IMPALA-14719: Fixed race condition for Calcite property
......................................................................
IMPALA-14719: Fixed race condition for Calcite property
IMPALA-14710 was filed for a flaky test involving the
calcite.default.charset property. Setting this property
before the jar file is loaded fixes this issue.
This commit also fixes two other issues:
- IMPALA-14384: Class.forName() is only called once now. The compiler
factory is stored in a singleton.
- The Calcite planner is now part of the build and should be in the
target directory. If the user explicitly sets the calcite planner
option and the calcite jar file not found, an error is thrown rather
than falling back.
Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteCompilerFactory.java
2 files changed, 18 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/23935/4
--
To view, visit http://gerrit.cloudera.org:8080/23935
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I80a0207150cf521c297b12a24075ae5f29c5c5ff
Gerrit-Change-Number: 23935
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>