Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23811 )

Change subject: IMPALA-14641: Add detailed operation page for Catalogd 
operations
......................................................................


Patch Set 7:

> Patch Set 7:
>
> The following tests failed or errored out which I feel is unrelated from our 
> changes:
> FAILED 
> custom_cluster/test_admission_controller.py::TestAdmissionController::test_coord_only_pool_happy_path["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 5000, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 
> 1}"]
> FAILED 
> custom_cluster/test_admission_controller.py::TestAdmissionController::test_coord_only_pool_no_executors["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 5000, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 
> 1}"]
> FAILED 
> custom_cluster/test_admission_controller.py::TestAdmissionController::test_coord_only_pool_one_coord_quiescing["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 5000, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 
> 1}"]
> FAILED 
> custom_cluster/test_admission_controller.py::TestAdmissionController::test_coord_only_pool_one_coord_terminate["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 5000, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 
> 1}"]
> FAILED 
> custom_cluster/test_admission_controller.py::TestAdmissionController::test_coord_only_pool_add_coord["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 5000, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 
> 1}"]
> FAILED 
> custom_cluster/test_admission_controller.py::TestAdmissionController::test_coord_only_pool_exec_groups["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 5000, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 
> 1}"]
> FAILED 
> custom_cluster/test_sys_db.py::TestSysDb::test_query_log_table_create_table_sys_db_blocked
> ERROR 
> custom_cluster/test_query_live.py::TestQueryLive::test_default_transactional
> ERROR custom_cluster/test_query_live.py::TestQueryLive::test_local_catalog - 
> ...
> ERROR custom_cluster/test_query_live.py::TestQueryLive::test_redaction - 
> Asse...
> ERROR 
> custom_cluster/test_query_live.py::TestQueryLive::test_dedicated_coordinators
> ERROR 
> custom_cluster/test_query_live.py::TestQueryLive::test_query_entries_are_unique
> ERROR 
> custom_cluster/test_query_live.py::TestQueryLive::test_missing_coordinator
> ERROR custom_cluster/test_query_live.py::TestQueryLive::test_multi_table_union
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogTableBasic::test_redaction["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 0, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 1}"]
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogTableHS2::test_with_experimental_profile
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogTableAll::test_ddl["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 0, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 1}"]
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogTableAll::test_invalid_query["table_format:
>  text/none" | "protocol: hs2" | "exec_option: {'abort_on_error': 1, 
> 'batch_size': 0, 'disable_codegen': False, 'disable_codegen_rows_threshold': 
> 0, 'exec_single_node_rows_threshold': 0, 'num_nodes': 0, 'test_replan': 1}"]
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogTableBufferPool::test_select["table_format:
>  text/none" | "protocol: hs2" | "buffer_pool_limit: None" | "exec_option: 
> {'abort_on_error': 1, 'batch_size': 0, 'disable_codegen': False, 
> 'disable_codegen_rows_threshold': 0, 'exec_single_node_rows_threshold': 0, 
> 'num_nodes': 0, 'test_replan': 1}"]
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogQueuedQueries::test_query_queued
> ERROR 
> custom_cluster/test_query_log.py::TestQueryLogTableFlush::test_flush_on_queued_count_exceeded

If you believe the tests failed previously, please find the tickets matching 
these failures.

I don't recognize these as problematic tests, and this is a lot of concurrent 
new failures. So I think it's very likely these started failing as a result of 
the patch. Please look into the failure output and try the tests locally.


--
To view, visit http://gerrit.cloudera.org:8080/23811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c
Gerrit-Change-Number: 23811
Gerrit-PatchSet: 7
Gerrit-Owner: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Arnab Karmakar <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Surya Hebbar <[email protected]>
Gerrit-Comment-Date: Thu, 05 Feb 2026 16:54:39 +0000
Gerrit-HasComments: No

Reply via email to