Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23811 )
Change subject: IMPALA-14641: Add detailed operation page for Catalogd operations ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/23811/5/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java File fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java: http://gerrit.cloudera.org:8080/#/c/23811/5/fe/src/main/java/org/apache/impala/catalog/monitor/CatalogOperationTracker.java@168 PS5, Line 168: String coordinator = "unknown"; > Thanks for pointing this, yes we should not update finished records. I think it's OK to make a compromise - allow updating the responseSize for a finished record once. We can add the record in JniCatalog instead of in increment() and let increment() update the record with other fields. http://gerrit.cloudera.org:8080/#/c/23811/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23811/8/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@483 PS8, Line 483: , catalogTimeline, : requestSizeBytes I'm confused why we need to pass these. They are created in JniCatalog. Can we add the record in JniCatalog and set these two fields during that? http://gerrit.cloudera.org:8080/#/c/23811/8/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/23811/8/fe/src/main/java/org/apache/impala/service/JniCatalog.java@352 PS8, Line 352: CatalogOperationTracker.INSTANCE.decrement(params.ddl_type, queryId, : /*errorMsg*/null, timeline, responseSize); Let's allow updating responseSize of archived records so don't need to move decrement() here. Timeline is already added when the record is created, so I don't think we need to set it again here. -- To view, visit http://gerrit.cloudera.org:8080/23811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib80ce3b5873672065b04b00a21d3419a1db0969c Gerrit-Change-Number: 23811 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 11 Feb 2026 13:55:03 +0000 Gerrit-HasComments: Yes
