Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23833 )
Change subject: IMPALA-14341: Iceberg MetaProviders Blacklist DBs/Tables ...................................................................... Patch Set 19: (3 comments) http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java File fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java: http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java@37 PS18, Line 37: TableName> BLACKLISTE > Set.size() should have O(1) complexity, so I'm not sure that the extra book Done http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java@70 PS18, Line 70: > nit: +4 indent is needed Done http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java File fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java: http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java@73 PS18, Line 73: equalTo(EXPECTED_METHOD_COUNT) > Maybe we could also directly compare it to MetaProviderDecorator.class.getD Good point. We need both asserts. This existing assert catches the case where a new method is added to the MetaProvider interface and also to the MetaProviderDecorator abstract class. When that happens, this test will fail prompting the change author to add a new test case to the `testAllMethodsDelegation` junit test. I added an assert that compares the number of declared methods on the MetaProvider interface and to the number of declared methods on the MetaProviderDecorator abstract class. This ensures that future change authors will be prompted to add a pass-through method on MetaProviderDecorator for the new method to the internal decorated object. -- To view, visit http://gerrit.cloudera.org:8080/23833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73a06d30dcdbb579f92c2afa5928beb6c5a13348 Gerrit-Change-Number: 23833 Gerrit-PatchSet: 19 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 19:26:00 +0000 Gerrit-HasComments: Yes
