Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23833 )
Change subject: IMPALA-14341: Iceberg MetaProviders Blacklist DBs/Tables ...................................................................... Patch Set 18: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java File fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java: http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java@37 PS18, Line 37: BLACKLISTED_DBS_COUNT Set.size() should have O(1) complexity, so I'm not sure that the extra bookkeeping is beneficial. http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/main/java/org/apache/impala/util/CatalogBlacklistUtils.java@70 PS18, Line 70: nit: +4 indent is needed http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java File fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java: http://gerrit.cloudera.org:8080/#/c/23833/18/fe/src/test/java/org/apache/impala/catalog/local/MetaProviderDecoratorTest.java@73 PS18, Line 73: equalTo(EXPECTED_METHOD_COUNT) Maybe we could also directly compare it to MetaProviderDecorator.class.getDeclaredMethods().length? -- To view, visit http://gerrit.cloudera.org:8080/23833 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I73a06d30dcdbb579f92c2afa5928beb6c5a13348 Gerrit-Change-Number: 23833 Gerrit-PatchSet: 18 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 05 Feb 2026 13:56:11 +0000 Gerrit-HasComments: Yes
