Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/23945 )
Change subject: IMPALA-14665: Upgrade Iceberg to 1.10.1 ...................................................................... Patch Set 1: Code-Review+1 (3 comments) Thanks, Zoltan. I left some minor comments. http://gerrit.cloudera.org:8080/#/c/23945/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23945/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2948 PS1, Line 2948: String deleteVectors = Long.toString(metrics.dvs().value()); is this intentionally left in? http://gerrit.cloudera.org:8080/#/c/23945/1/java/shaded-deps/impala-iceberg-runtime/pom.xml File java/shaded-deps/impala-iceberg-runtime/pom.xml: http://gerrit.cloudera.org:8080/#/c/23945/1/java/shaded-deps/impala-iceberg-runtime/pom.xml@3 PS1, Line 3: Licensed under the Apache License, Version 2.0 (the "License"); The license text looks different from the one that we use elsewhere http://gerrit.cloudera.org:8080/#/c/23945/1/java/shaded-deps/impala-iceberg-runtime/pom.xml@15 PS1, Line 15: <project xmlns="http://maven.apache.org/POM/4.0.0"; this line is usually left without wrapping -- To view, visit http://gerrit.cloudera.org:8080/23945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e6f8e7e8e9e85faa992d7cc0165c92687d13bc0 Gerrit-Change-Number: 23945 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 13:16:20 +0000 Gerrit-HasComments: Yes
