Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23945 )
Change subject: IMPALA-14665: Upgrade Iceberg to 1.10.1 ...................................................................... Patch Set 2: (3 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23945/1/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/23945/1/fe/src/main/java/org/apache/impala/service/Frontend.java@2948 PS1, Line 2948: String deleteVectors = Long.toString(metrics.dvs().value()); > is this intentionally left in? Yes, in this method we add all fileds of ScanMetricsResult to the profile. http://gerrit.cloudera.org:8080/#/c/23945/1/java/shaded-deps/impala-iceberg-runtime/pom.xml File java/shaded-deps/impala-iceberg-runtime/pom.xml: http://gerrit.cloudera.org:8080/#/c/23945/1/java/shaded-deps/impala-iceberg-runtime/pom.xml@3 PS1, Line 3: Licensed to the Apache Software Foundation (ASF) under one > The license text looks different from the one that we use elsewhere Hm, I copy-pasted it from the other pom.xml files under shaded-deps. Updated the licenses in them. http://gerrit.cloudera.org:8080/#/c/23945/1/java/shaded-deps/impala-iceberg-runtime/pom.xml@15 PS1, Line 15: "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY > this line is usually left without wrapping In this directory they are all wrapped (hive-exec/pom.xml, s3a-aws-sdk.xml). If you are not strongly against it, I'd leave it as is for readability. -- To view, visit http://gerrit.cloudera.org:8080/23945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e6f8e7e8e9e85faa992d7cc0165c92687d13bc0 Gerrit-Change-Number: 23945 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 09 Feb 2026 11:50:44 +0000 Gerrit-HasComments: Yes
