Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@961 PS1, Line 961: protected void process() throws MetastoreNotificationException { We need to handle CommitTxnEvent as well. 'tableNames_' are populated from 'tableWriteIds_' in addCommittedWriteIdsToTables(). We can move that logic into the constructor then we know what tables to invalidate here. http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3111 PS1, Line 3111: if (isSelfEvent()) { Self-event detection for partition level events could be stuck in waiting for table lock (IMPALA-12461). We should move handleIfInCatchUpMode() before this. http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23942/1/tests/custom_cluster/test_events_custom_configs.py@709 PS1, Line 709: We'd better add more tests to cover other event types that support this mode. Also add tests for CommitTxnEvent. -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 14:55:36 +0000 Gerrit-HasComments: Yes
