[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/23942 )
Change subject: IMPALA-14230: Add catch-up mode for event processing ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java File fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java@1158 PS1, Line 1158: protected void processTableEvent() throws MetastoreNotificationException { Missed to handle for PseudoCommitTxnEvent. http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1210 PS1, Line 1210: if (catalog_.invalidateTableIfExists(dbName_, tblName_) != null) { May be it is good to avoid this call if the table is already IncompleteTable so as to avoid unnecessary table change updates. http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1954 PS1, Line 1954: if (handleIfInCatchUpMode()) return; How about we call this method in org.apache.impala.catalog.events.MetastoreEvents.MetastoreTableEvent#process() just before processTableEvent() instead of calling it in each of these instances? And irrespective of return value of handleIfInCatchUpMode() call processTableEvent(). I mean, like this - { handleIfInCatchUpMode(); processTableEvent(); } http://gerrit.cloudera.org:8080/#/c/23942/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@3711 PS1, Line 3711: try { Missed to handle for AbortTxnEvent. -- To view, visit http://gerrit.cloudera.org:8080/23942 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib906c06346d5d3159999eeac632e1318bc060065 Gerrit-Change-Number: 23942 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 22:07:02 +0000 Gerrit-HasComments: Yes
