Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844: Support setting DBPROPERTIES ...................................................................... Patch Set 14: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/23905/14/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java: http://gerrit.cloudera.org:8080/#/c/23905/14/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java@31 PS14, Line 31: nit: extra line http://gerrit.cloudera.org:8080/#/c/23905/14/fe/src/test/java/org/apache/impala/analysis/ParserTest.java File fe/src/test/java/org/apache/impala/analysis/ParserTest.java: http://gerrit.cloudera.org:8080/#/c/23905/14/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2292 PS14, Line 2292: ParsesOk(String.format( : "CREATE %s Foo COMMENT 'comment' WITH DBPROPERTIES('a'='b')", kw)); : ParsesOk(String.format( : "CREATE %s Foo COMMENT 'comment' WITH DBPROPERTIES('a'='b') " + : "LOCATION '/hdfs/location'", kw)); nit: inconsistant indentation -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 14 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 12 Feb 2026 12:01:31 +0000 Gerrit-HasComments: Yes
