Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23905 )
Change subject: IMPALA-12844: Support setting DBPROPERTIES ...................................................................... Patch Set 13: (5 comments) http://gerrit.cloudera.org:8080/#/c/23905/12//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23905/12//COMMIT_MSG@14 PS12, Line 14: > nit: you could mention about testing here Done http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java: http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/analysis/AlterDbSetDbPropertiesStmt.java@22 PS12, Line 22: import org.apache.impala.authorization.Privilege; : import org.apache.impala.common.AnalysisException; : import org.apache.impala.thrift.TAlterDbParams; > nit: unused imports. Also at L#28,31,32 Done http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@8497 PS12, Line 8497: ame); > nit: I just noticed that we already called params.getSet_owner_params() at Done http://gerrit.cloudera.org:8080/#/c/23905/12/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@8503 PS12, Line 8503: setDbPropertiesParams.properties.entrySet()) : msDb.putToParameters(property.getKey > We could move the declaration of setDbPropertiesParams before the first swi Done http://gerrit.cloudera.org:8080/#/c/23905/12/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/23905/12/tests/custom_cluster/test_events_custom_configs.py@1882 PS12, Line 1882: def run_test(alter_dbproperties_in_impala): > I think it is better to add a new test to verify the alter database set pro For verifying the result of the alter database query, a new test was added here: https://gerrit.cloudera.org/#/c/23905/12/tests/metadata/test_ddl.py The reason for the change in the test here is to specifically verify that altering impala.disableHmsSync property does take effect even if called in Impala. -- To view, visit http://gerrit.cloudera.org:8080/23905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I628c7bed4f0c39aed7f5f4ffea52421caf501933 Gerrit-Change-Number: 23905 Gerrit-PatchSet: 13 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 06 Feb 2026 07:52:55 +0000 Gerrit-HasComments: Yes
