Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23963 )
Change subject: IMPALA-14575: Add constant handling for Hive GenericUDFs ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/23963/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23963/11//COMMIT_MSG@40 PS11, Line 40: Testing: Can you look through the existing tests to check if all types are covered with non-const args? My concern is that many tests use const args which won't be sent to JVM per row after this patch. Generic UDFs are covered after this patch for all types, but legacy udfs with writable/Java type arguments may not be covered. http://gerrit.cloudera.org:8080/#/c/23963/10/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test File testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test: http://gerrit.cloudera.org:8080/#/c/23963/10/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test@383 PS10, Line 383: select alltypeargs_constcheck(true, tinyint_col, smallint_col, int_col, bigint_col, : float_col, double_col, string_col, cast("const string" as binary)) : from functional.alltypestiny; Can you cover all types with both const and non-const? My idea would be to set one half of arguments const in one query, then the other half in the other query. -- To view, visit http://gerrit.cloudera.org:8080/23963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a6ca8c0bab499dffed88bb9786753da559af4c5 Gerrit-Change-Number: 23963 Gerrit-PatchSet: 11 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 19 Feb 2026 18:27:00 +0000 Gerrit-HasComments: Yes
