Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/23963 )
Change subject: IMPALA-14575: Add constant handling for Hive GenericUDFs ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/23963/11//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23963/11//COMMIT_MSG@23 PS11, Line 23: > As discussed offline, can you also add an example with a more complex predi Done http://gerrit.cloudera.org:8080/#/c/23963/11//COMMIT_MSG@40 PS11, Line 40: ); > Can you look through the existing tests to check if all types are covered w Good idea, there are some tests here and there, but sometimes the value is only used indirectly (e.g. in a where clause), so I added a query to java-udf.test that directly outputs some values through an (identity) UDF call http://gerrit.cloudera.org:8080/#/c/23963/10/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test File testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test: http://gerrit.cloudera.org:8080/#/c/23963/10/testdata/workloads/functional-query/queries/QueryTest/generic-java-udf.test@383 PS10, Line 383: select alltypeargs_constcheck(true, 1, 2, 3, 4, : float_col, double_col, string_col, cast(string_col as binary)) : from functional.alltypestiny; > Can you cover all types with both const and non-const? Done -- To view, visit http://gerrit.cloudera.org:8080/23963 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a6ca8c0bab499dffed88bb9786753da559af4c5 Gerrit-Change-Number: 23963 Gerrit-PatchSet: 12 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 20 Feb 2026 13:50:41 +0000 Gerrit-HasComments: Yes
