Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23724 )
Change subject: IMPALA-14429: Calcite planner: change mechanism for parsing tinyint, smallint ...................................................................... Patch Set 9: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23724/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java: http://gerrit.cloudera.org:8080/#/c/23724/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexBuilder.java@69 PS9, Line 69: type.getSqlTypeName().equals(SqlTypeName.INTEGER) It seems to me any exact numeric type (there are 9 such types in Calcite) can be a candidate for converting to Impala's literal type. Can we use SqlTypeUtil.isExactNumeric() here without introducing side effects ? -- To view, visit http://gerrit.cloudera.org:8080/23724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I67b6f7711093a4b8488beee0893aea3c72239eb0 Gerrit-Change-Number: 23724 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 22 Feb 2026 06:37:24 +0000 Gerrit-HasComments: Yes
