anujphadke has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 )
Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10740/2/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/10740/2/be/src/util/network-util.cc@196 PS2, Line 196: server_address.sin_port = htons(port); I think we can set this to 0 and bind to a random port instead of looping through to find a random port? -- To view, visit http://gerrit.cloudera.org:8080/10740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fcc9243099f8249380ac5f01ac5eb67cba24cf5 Gerrit-Change-Number: 10740 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Tue, 19 Jun 2018 23:05:47 +0000 Gerrit-HasComments: Yes
