Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10740 )
Change subject: IMPALA-7151: Rework ephemeral port assignment for be tests ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/10740/4/be/src/statestore/statestore-subscriber.cc File be/src/statestore/statestore-subscriber.cc: http://gerrit.cloudera.org:8080/#/c/10740/4/be/src/statestore/statestore-subscriber.cc@223 PS4, Line 223: heartbeat_address_.port = heartbeat_server_->port(); > Are we sure that setting this outside the scope of 'lock_' won't cause any Am I misreading something - isn't this within the same scoped block as exclusive_lock? -- To view, visit http://gerrit.cloudera.org:8080/10740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fcc9243099f8249380ac5f01ac5eb67cba24cf5 Gerrit-Change-Number: 10740 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: anujphadke <[email protected]> Gerrit-Comment-Date: Wed, 20 Jun 2018 17:40:42 +0000 Gerrit-HasComments: Yes
