Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24026 )
Change subject: IMPALA-14776 (part 1): Use context managers for manually created clients ...................................................................... Patch Set 1: (20 comments) http://gerrit.cloudera.org:8080/#/c/24026/1/tests/authorization/test_ranger.py File tests/authorization/test_ranger.py: http://gerrit.cloudera.org:8080/#/c/24026/1/tests/authorization/test_ranger.py@114 PS1, Line 114: ) > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/authorization/test_ranger.py@2771 PS1, Line 2771: \ > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/authorization/test_ranger.py@2819 PS1, Line 2819: ) > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/authorization/test_ranger.py@2822 PS1, Line 2822: ) > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/authorization/test_ranger.py@3999 PS1, Line 3999: m > flake8: U100 Unused argument 'method' Fixed this to call the super teardown_method http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_breakpad.py@207 PS1, Line 207: ) > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_executor_groups.py@780 PS1, Line 780: e > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_executor_groups.py@852 PS1, Line 852: l > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_re2_max_mem.py File tests/custom_cluster/test_re2_max_mem.py: http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_re2_max_mem.py@39 PS1, Line 39: l > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_udf_concurrency.py File tests/custom_cluster/test_udf_concurrency.py: http://gerrit.cloudera.org:8080/#/c/24026/1/tests/custom_cluster/test_udf_concurrency.py@82 PS1, Line 82: e > flake8: F841 local variable 'e' is assigned to but never used Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@522 PS1, Line 522: ) > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@527 PS1, Line 527: ) > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@597 PS1, Line 597: ) > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@605 PS1, Line 605: a > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@662 PS1, Line 662: l > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@724 PS1, Line 724: n > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@727 PS1, Line 727: 9 > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@743 PS1, Line 743: n > flake8: E501 line too long (91 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@744 PS1, Line 744: i > flake8: E501 line too long (92 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/24026/1/tests/metadata/test_event_processing.py@746 PS1, Line 746: 9 > flake8: E501 line too long (92 > 90 characters) Done -- To view, visit http://gerrit.cloudera.org:8080/24026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib550527838a81cd2aaf69bb715080f6ac6da3786 Gerrit-Change-Number: 24026 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 06:58:19 +0000 Gerrit-HasComments: Yes
