Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24026 )
Change subject: IMPALA-14776 (part 1): Use context managers for manually created clients ...................................................................... Patch Set 2: (2 comments) I've reworked this to avoid touching all of the test code. It now registers the client when it is created and cleans it up during test method teardown. http://gerrit.cloudera.org:8080/#/c/24026/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24026/2//COMMIT_MSG@8 PS2, Line 8: > Not sure if you are aware of my patch https://gerrit.cloudera.org/#/c/23992 Yeah, I was focusing on different things. Now it is in, so I'm stacking on top of that change. http://gerrit.cloudera.org:8080/#/c/24026/2//COMMIT_MSG@20 PS2, Line 20: This modifies most locations using these APIs to use with-as or : try-finally blocks to guarantee cleanup. > I was also thinking about how to handle these, and adding a "with" everywhe Good point, I changed this to maintain a list of clients and clean them up at the end of a test method. To keep it minimal, I'm not really touching any of the test code. -- To view, visit http://gerrit.cloudera.org:8080/24026 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib550527838a81cd2aaf69bb715080f6ac6da3786 Gerrit-Change-Number: 24026 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 26 Feb 2026 05:43:08 +0000 Gerrit-HasComments: Yes
