Hello Aman Sinha, Joe McDonnell, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23951
to look at the new patch set (#9).
Change subject: IMPALA-14525 addendum: For simplify, nulls should only be
treated as false for filters
......................................................................
IMPALA-14525 addendum: For simplify, nulls should only be treated as false for
filters
The previous fix for IMPALA-14525 simplifies expressions. Calcite has a
parameter for the simplify method which allows "unknown" expressions to
be treated as "unknown" or "false". For filters, we do want to treat Unknowns
as False since a filter can only be true or false. However for expressions
in other parts of the code like select (e.g. select 1 in (NULL) ), the null
needs to be treated as "unknown" so that the simplify method can return null
for this expression.
Change-Id: I673162f253f983e0c95d01b1f8d2731881f9ad7b
---
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/rules/ImpalaFilterSimplifyRule.java
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
3 files changed, 19 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/51/23951/9
--
To view, visit http://gerrit.cloudera.org:8080/23951
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I673162f253f983e0c95d01b1f8d2731881f9ad7b
Gerrit-Change-Number: 23951
Gerrit-PatchSet: 9
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
