Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23951 )
Change subject: IMPALA-14525 addendum: For simplify, nulls should only be treated as false for filters ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23951/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java: http://gerrit.cloudera.org:8080/#/c/23951/8/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaRexSimplify.java@42 PS8, Line 42: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaRexSimplify.class.getName()); > Why did this patch add LOG? It's unused. No good reason, used it for debugging and forgot to remove. -- To view, visit http://gerrit.cloudera.org:8080/23951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I673162f253f983e0c95d01b1f8d2731881f9ad7b Gerrit-Change-Number: 23951 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 24 Feb 2026 16:24:04 +0000 Gerrit-HasComments: Yes
