Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24022 )
Change subject: IMPALA-14691: Only log modified query options ...................................................................... Patch Set 2: Code-Review+1 (1 comment) I ran this locally, and this looks good to me. I think it makes sense to reuse the DebugQueryOptions function. http://gerrit.cloudera.org:8080/#/c/24022/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24022/2//COMMIT_MSG@13 PS2, Line 13: Most of the time, most, if not all, query options are not overridden, : and use the default value. Logging only the modified values gives a : shorter and more understandable information, as the full list is very : long. : : A function to extract the necessary list of modified values already : exists (DebugQueryOptions), and is used e.g. in query profile. Can you add a sentence about how this interacts with the --default_query_options startup option? -- To view, visit http://gerrit.cloudera.org:8080/24022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcd9eb80afaa3171f5436cabb4703bbae4581396 Gerrit-Change-Number: 24022 Gerrit-PatchSet: 2 Gerrit-Owner: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Wed, 25 Feb 2026 21:04:38 +0000 Gerrit-HasComments: Yes
